append /run/cluster-api/bootstrap-success.complete #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Mazzotti <[email protected]>
zawachte
reviewed
Dec 6, 2023
| @@ -27,7 +27,7 @@ const ( | |||
| {{template "files" .WriteFiles}} | |||
| runcmd: | |||
| {{- template "commands" .PreK3sCommands }} | |||
| - 'curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=%s sh -s - server' | |||
| - 'curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=%s sh -s - server && mkdir -p /run/cluster-api && echo success > /run/cluster-api/bootstrap-success.complete' | |||
There was a problem hiding this comment.
what is your opinion of just adding this as a separate command rather than chaining it?
I prefer this approach as i find it more readable and easier to debug on failed nodes, but that is just my two cents.
There was a problem hiding this comment.
A separate command would be incorrect, please check the comment above.
There was a problem hiding this comment.
oh i see thanks. hmm we should probably make an issue to just create a bootstrap script like the kubeadm providers.
zawachte
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes the creation of the
/run/cluster-api/bootstrap-success.completeas documented by the Bootstrap provider contractThe reason for the one line is that cloud-init is going to execute all commands in the
runcmdlist, in spite of errors.So the following would be incorrect, as the
/run/cluster-api/bootstrap-success.completewould be created even in case of bootstrap failures.